Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| * @throws ValidationException if the module is null | ||
| */ | ||
| public void registerJacksonModule(Module module) { | ||
| public void registerJacksonModule(JacksonModule module) { |
There was a problem hiding this comment.
it would proabably make sense to get rid of this method since the ObjectMapper is immutable after construction in jackson 3. passing the JacksonModules as constructor parameters and initializing the ObjectMapper in the constructor would probably be better - similar to how it's already done in KNO2JacksonMapper
DarkAtra
force-pushed
the
upgrade-to-jackson-3
branch
8 times, most recently
from
af3ab63 to
7efca6b
Compare
DarkAtra
force-pushed
the
upgrade-to-jackson-3
branch
from
7efca6b to
900aebb
Compare
1 participant
No description provided.